Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import JujuVersion from ops.jujuversion instead of model #639

Closed
wants to merge 1 commit into from

Conversation

IronCore864
Copy link
Contributor

Issue

#638

Solution

Import JujuVersion from ops.jujuversion instead of ops.model.

Current, importing JujuVersion from ops.model works but only because ops.model happens to import JujuVersion from ops.jujuversion. This will be changed soon, so we should import JujuVersionfromops.jujuversion`.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (e760a3d) to head (7fe261c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   70.71%   70.72%   +0.01%     
==========================================
  Files          11       11              
  Lines        2926     2927       +1     
  Branches      511      511              
==========================================
+ Hits         2069     2070       +1     
  Misses        748      748              
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IronCore864 IronCore864 deleted the patch-1 branch August 19, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant