Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against juju 3.6/candidate + upgrade dpw to v23.0.5 #675

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

shayancanonical
Copy link
Contributor

Issue

  1. There's a new juju release candidate, on 3.6/candidate
  2. There's a new dpw version (which we need to update to before Nov 21 to avoid failing tests)

Solution

  1. Run nightly tests against juju 3.6/candidate
  2. Upgrade to dpw v23.0.5

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (3f31bbf) to head (f5e3aed).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          13       13           
  Lines        3189     3189           
  Branches      475      475           
=======================================
  Hits         2277     2277           
  Misses        797      797           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shayancanonical
Copy link
Contributor Author

Sorry, realized that this PR does not update dpw in pyproject.toml and subsequently does not update the project poetry lock file. However, this will be automated in a separate PR by renovate

@shayancanonical shayancanonical merged commit 1b6a748 into main Nov 18, 2024
97 checks passed
@shayancanonical shayancanonical deleted the feature/juju_3_6_candidate branch November 18, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants