Add params to allowed scrape jobs keys #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Params allows to specify HTTP query parameters to append to a metrics_path.
gboutry
requested review from
sed-i,
Abuelodelanada,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
Abuelodelanada
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Params allows to specify HTTP query parameters to append to a metrics_path.
Issue
Some metrics endpoint need query arguments to resolve properly.
Fix #541
Solution
Add
paramsto allowed scrape jobs keys.Context
openstack-exporter requires the cloud name to be passed as query arguments (as it can monitor multiple cloud definitions)
Testing Instructions
Create a job specifying params.
Release Notes
Add params to allowed scrape jobs keys