Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix rocks terminology #51

Merged
merged 1 commit into from
May 24, 2024

Conversation

cjdcordeiro
Copy link
Contributor

Issue

"ROCK" should be "rock"

Solution

Replacing all occurrences

Context

Testing Instructions

Upgrade Notes

Copy link
Contributor

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good, but most likely we'll need signed commits here as well.

@cjdcordeiro cjdcordeiro force-pushed the ROCKS-1171/fix-rocks-terminology branch from b019574 to 8c16ffc Compare May 24, 2024 10:02
@cjdcordeiro
Copy link
Contributor Author

The commit is now signed

@cjdcordeiro cjdcordeiro requested a review from mmkay May 24, 2024 10:03
@mmkay mmkay merged commit 93cd957 into canonical:main May 24, 2024
1 check passed
@mmkay
Copy link
Contributor

mmkay commented May 24, 2024

Thank you for the contribution, @cjdcordeiro! The PRs should now be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants