Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add kubeflow seldon aggregation rules #122

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: add kubeflow seldon aggregation rules #122

merged 1 commit into from
Mar 24, 2023

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Mar 24, 2023

Fixes #113

@DnPlas DnPlas requested a review from a team as a code owner March 24, 2023 12:33
ca-scribner
ca-scribner approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming it passes the final test

@DnPlas
Copy link
Contributor Author

DnPlas commented Mar 24, 2023 •
edited
Loading

Testing the change:

ubuntu@ip-172-31-13-175:~$ kubectl auth can-i create seldondeployments --as=system:serviceaccount:admin:default-editor -nadmin
yes
ubuntu@ip-172-31-13-175:~$ kubectl auth can-i create seldondeployments --as=system:serviceaccount:admin:default-editor -nkubeflow
no
ubuntu@ip-172-31-13-175:~$ kubectl auth can-i create seldondeployments --as=system:serviceaccount:admin:default-editor -ndefault
no

Before applying the aggregation clusterrole:

ubuntu@ip-172-31-13-175:~$ kubectl auth can-i create seldondeployments --as=system:serviceaccount:admin:default-editor -ndefault
no
ubuntu@ip-172-31-13-175:~$ kubectl auth can-i create seldondeployments --as=system:serviceaccount:admin:default-editor -nadmin
no

@DnPlas DnPlas merged commit 92b09e1 into track/1.15 Mar 24, 2023
@DnPlas DnPlas deleted the KF-1554-fix-113 branch March 24, 2023 15:19
@DnPlas DnPlas mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ca-scribner ca-scribner ca-scribner approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DnPlas @ca-scribner