Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic spread infrastructure #6

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Jan 9, 2024

I'm keeping this PR as a Draft until the spread tests are actually running on CI, but maybe we can expedite the review with what we have so far.
The first commit has the spread-related code, and the second commit has the ci-related changes.

@tigarmo tigarmo force-pushed the CRAFT-2381-basic-spread branch 7 times, most recently from bd3fdeb to 0f6f595 Compare January 10, 2024 19:34
@tigarmo tigarmo changed the title Craft 2381 basic spread add basic spread infrastructure Jan 10, 2024
@tigarmo tigarmo requested review from lengau and mr-cal January 10, 2024 19:51
Copy link

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

spread.yaml Outdated Show resolved Hide resolved
Copy link

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just added some minor comments that you are free to disregard.

spread.yaml Outdated Show resolved Hide resolved
tests/spread/general/hello/task.yaml Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
@tigarmo tigarmo marked this pull request as ready for review January 11, 2024 18:25
@tigarmo tigarmo merged commit 0b40915 into core22-7 Jan 11, 2024
2 checks passed
@tigarmo tigarmo deleted the CRAFT-2381-basic-spread branch January 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants