Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add V2 Ruby plugin #3511

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

add V2 Ruby plugin #3511

wants to merge 10 commits into from

Conversation

paddor
Copy link

@paddor paddor commented Apr 23, 2021

@sergiusens
Copy link
Collaborator

Thanks for collaborating on this. Looks good, I have a couple of suggestions to make (aside from testing) that I will propose as soon as I have some time available

Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, have a few suggestions - thanks!

snapcraft/plugins/v2/ruby.py Outdated Show resolved Hide resolved
snapcraft/plugins/v2/ruby.py Outdated Show resolved Hide resolved
snapcraft/plugins/v2/ruby.py Outdated Show resolved Hide resolved
snapcraft/plugins/v2/ruby.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How complicated would it be to have ruby as a content snap and deliver the entire hookup through an extension?

snapcraft/plugins/v2/ruby.py Outdated Show resolved Hide resolved
snapcraft/plugins/v2/ruby.py Outdated Show resolved Hide resolved
snapcraft/plugins/v2/ruby.py Outdated Show resolved Hide resolved
@sergiusens
Copy link
Collaborator

And apologies for the late response, I had an intense event and a full disconnect afterwards.

@paddor
Copy link
Author

paddor commented May 20, 2021

How complicated would it be to have ruby as a content snap and deliver the entire hookup through an extension?

I'm sorry, but I don't understand the question. Content snap? Hookup?

What I'm already doing in a project is using this plugin in a part of its own without a source:-line, so Ruby doesn't have to be recompiled after every change in the project source code. Is that what you mean?

paddor and others added 7 commits May 20, 2021 12:06
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@paddor
Copy link
Author

paddor commented Dec 22, 2022

Please review.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paddor,

Apologies for the long delay in reviews. I'm happy to help you drive this and canonical/craft-parts#341 to completion.

I think next step is an integration test that builds a "hello world" Ruby app. You would need to add the test here and the source files for the app in a directory here. Testing this requires installing spread and running it locally with Multipass.

Alternatively, you could add the "hello world" integration test in craft-parts here (which doesn't use spread) and I can help translate it to a spread test in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants