Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde-neon-extension: New content snap for kf5 5.98 and qt 5.15.6 #3925

Merged
merged 9 commits into from
Nov 23, 2022
Merged

kde-neon-extension: New content snap for kf5 5.98 and qt 5.15.6 #3925

merged 9 commits into from
Nov 23, 2022

Conversation

ScarlettGatelyMoore
Copy link
Contributor

  • [x ] Have you followed the guidelines for contributing?
  • [x ] Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

mypy setup.py snapcraft tests/*.py tests/unit
snapcraft/snap_config.py:27: error: Unexpected keyword argument "extra" for "init_subclass" of "object"
snapcraft/projects.py:321: error: Unexpected keyword argument "extra" for "init_subclass" of "object"
snapcraft/projects.py:641: error: Unexpected keyword argument "extra" for "init_subclass" of "object"
Found 3 errors in 2 files (checked 166 source files)
make: *** [Makefile:30: test-mypy] Error 1

pytest-3 tests/unit
ImportError while loading conftest '/home/scarlett/snapcraft/tests/conftest.py'.
tests/conftest.py:22: in
from craft_store.auth import MemoryKeyring
E ModuleNotFoundError: No module named 'craft_store

@ppd
Copy link
Contributor

ppd commented Sep 27, 2022

@ScarlettGatelyMoore The content snap must auto connect for the tests to pass; this needs to be requested on the forums.

@ScarlettGatelyMoore
Copy link
Contributor Author

Signed the CLA, sorry thought I did already

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #3925 (df562af) into main (97ab497) will not change coverage.
The diff coverage is n/a.

❗ Current head df562af differs from pull request most recent head 43a5d76. Consider uploading reports for the commit 43a5d76 to get more accurate results

@@           Coverage Diff           @@
##             main    #3925   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files          56       56           
  Lines        4154     4154           
=======================================
  Hits         3780     3780           
  Misses        374      374           
Impacted Files Coverage Δ
snapcraft/providers.py 96.55% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens enabled auto-merge (squash) November 23, 2022 13:32
@sergiusens sergiusens merged commit 7870ff2 into canonical:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants