tests: allow local git submodules #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git v2.34.1 requires the config `protocol.file.allow=always` when adding a local submodule Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
sergiusens
approved these changes
Oct 20, 2022
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
|
We also need this fix in craft-parts to replace canonical/craft-parts#307. |
|
@cmatsuoka this is already fixed in craft-parts canonical/craft-parts@a7dfeaf |
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #3953 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 56 56
Lines 4072 4072
=======================================
Hits 3707 3707
Misses 365 365 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Oct 27, 2022
mr-cal
added a commit
to mr-cal/snapcraft
that referenced
this pull request
Oct 31, 2022
git v2.34.1 requires the config `protocol.file.allow=always` when adding a local submodule Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
4 tasks
cmatsuoka
pushed a commit
to cmatsuoka/snapcraft
that referenced
this pull request
Nov 10, 2022
git v2.34.1 requires the config `protocol.file.allow=always` when adding a local submodule Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
cmatsuoka
added a commit
that referenced
this pull request
Nov 10, 2022
tests: allow local git submodules (#3953) git v2.34.1 requires the config `protocol.file.allow=always` when adding a local submodule Co-authored-by: Callahan <callahan.kovacs@canonical.com> Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?git v2.34.1 requires the config
protocol.file.allow=alwayswhen adding a local submodule