Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers: log message when changing environment variables #3956

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 24, 2022

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Inside a build environment, entering a part's build directory will notify the user that the environment variables have been updated.

@mr-cal mr-cal force-pushed the build-environment-message branch from 8bb801c to 513473e Compare October 24, 2022 13:26
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the build-environment-message branch from 513473e to c8f7f5a Compare October 24, 2022 13:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Merging #3956 (554494f) into main (57cd1d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3956   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          56       56           
  Lines        4098     4098           
=======================================
  Hits         3732     3732           
  Misses        366      366           
Impacted Files Coverage Δ
snapcraft/providers.py 96.55% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal enabled auto-merge (squash) November 3, 2022 17:34
@mr-cal mr-cal merged commit 97ab497 into canonical:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants