Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: retry installing lxd snap #3957

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 24, 2022

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Use the retry function from snapd-testing-tools when installing the lxd snap.

This is to workaround an intermittent and hard-to-reproduce snapd bug.

⚠️ If you are having trouble running spread tests: Try fetching the git submodules (git submodule update --init --recursive) to collect the snapd-testing-tools submodule.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Merging #3957 (c9431b4) into main (3410375) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3957   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          56       56           
  Lines        4098     4098           
=======================================
  Hits         3732     3732           
  Misses        366      366           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the test-spread-retry-snap-install-lxd branch from b3dc1e6 to 991503b Compare October 24, 2022 20:34
@mr-cal mr-cal enabled auto-merge (squash) November 3, 2022 17:34
@mr-cal mr-cal merged commit 57cd1d9 into canonical:main Nov 16, 2022
@mr-cal mr-cal deleted the test-spread-retry-snap-install-lxd branch November 16, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants