-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: support top-level provenance
keyword for on-prem support
#3963
Conversation
The `provenance` key in snapcraft.yaml can now be moved from underneath `passthrough` to a top-level key. Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #3963 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 56 56
Lines 4083 4084 +1
=======================================
+ Hits 3718 3719 +1
Misses 365 365
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Spread failure unrelated (#3962) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! +1, but check comment, thanks!!
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Set to auto-merging, but I can't merge to main with 1 unrelated spread failure (resolved by #3962) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (but a test failed)
make lint
?pytest tests/unit
?The
provenance
key in snapcraft.yaml can now be moved from underneathpassthrough
to a top-level key.(CRAFT-1423)