Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Make test_patcher not require a real patchelf in /usr/bin #4003

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Dec 14, 2022

Discovered this accidentally thanks to a ~/.bashrc that put /bin before /usr/bin in $PATH.

I'm not entirely sure this was unintentional, so unless someone else knows we should probably wait for @sergiusens.

@lengau lengau changed the title Make test_patcher tests not require a real patchelf in /usr/bin Tests: Make test_patcher not require a real patchelf in /usr/bin Jan 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #4003 (a917454) into main (31a3990) will increase coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4003      +/-   ##
==========================================
+ Coverage   90.99%   91.61%   +0.61%     
==========================================
  Files          56       77      +21     
  Lines        4154     5153     +999     
==========================================
+ Hits         3780     4721     +941     
- Misses        374      432      +58     
Impacted Files Coverage Δ
snapcraft/providers.py 96.55% <0.00%> (ø)
snapcraft/store/client.py 95.43% <0.00%> (ø)
snapcraft/parts/yaml_utils.py 92.68% <0.00%> (ø)
snapcraft/commands/__init__.py 100.00% <0.00%> (ø)
snapcraft/ua_manager.py 96.38% <0.00%> (ø)
snapcraft/errors.py 91.17% <0.00%> (ø)
snapcraft/__main__.py 0.00% <0.00%> (ø)
snapcraft/meta/__init__.py 100.00% <0.00%> (ø)
snapcraft/plugins/v1/__init__.py 0.00% <0.00%> (ø)
snapcraft/__init__.py 72.72% <0.00%> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens merged commit 237fba4 into canonical:main Jan 13, 2023
@lengau lengau deleted the elf-patcher-tests branch January 13, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants