Testing: Lint and test using Tox #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
tox
branch
2 times, most recently
from
1d3f867 to
d86471b
Compare
lengau
force-pushed
the
tox
branch
6 times, most recently
from
c428d99 to
1343cfe
Compare
Codecov Report
@@ Coverage Diff @@
## main #4005 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 77 77
Lines 5153 5153
=======================================
Hits 4721 4721
Misses 432 432
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lengau
force-pushed
the
tox
branch
2 times, most recently
from
0b9abd5 to
fbd1b00
Compare
* Add tox >= 4.0 as a dev dependency * Add tox configuration to setup.cfg - I chose setup.cfg because pyproject.toml support in tox is awkward (tox-dev/tox#999) - Specified flake8 < 6.0.0 until we can get around to replacing type comments with type annotations. PyCQA/pyflakes#747 * Modify Makefile to use tox instead of running the commands directly * Update .gitignore for relevant new files and directories * Update requirements files - Newer tarball in freeze-requirements.sh because the older one was sometimes breaking in tox. * Set pylint configuration to ignore tests/legacy rather than manually excluding it A future commit will configure tox in Github actions.
Takes advantage of the multiple python versions now available. https://github.com/actions/setup-python/releases/tag/v4.4.0
Pylint fails on pydantic stuff if pydantic isn't installed Also reduce python version to 3.10
# Conflicts: # Makefile # pyproject.toml # setup.py
mr-cal
reviewed
Jan 13, 2023
tigarmo
reviewed
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures tox for linting and unit testing and provides a GitHub workflow for running Tox.
Does not disable old linting and testing yet for the sake of comparison.
(CRAFT-1513)