Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze ruff version #4016

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Freeze ruff version #4016

merged 1 commit into from
Jan 18, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Jan 17, 2023

Ruff is currently iterating quickly and adding many tests in each new version. This change will move ruff breakages into the renovate update PRs rather than random PRs.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@lengau lengau mentioned this pull request Jan 17, 2023
Merged
4 tasks
mr-cal
mr-cal approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you aren't updating ruff in requirements-devel.txt too?

@lengau
Freeze ruff version
3eb0474 
Ruff is currently iterating quickly and adding many tests in each new version.
This change will move ruff breakages into the renovate update PRs rather
than random PRs.
@lengau
Copy link
Contributor Author

lengau commented Jan 17, 2023

Any reason you aren't updating ruff in requirements-devel.txt too?

Oversight :-)

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #4016 (3eb0474) into main (5e14f6d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4016   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          77       77           
  Lines        5153     5153           
=======================================
  Hits         4721     4721           
  Misses        432      432

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal merged commit 5b8ad3d into canonical:main Jan 18, 2023
@lengau lengau deleted the freeze-ruff branch January 18, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @codecov-commenter @mr-cal