Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: pass --verbose and -v to snapcraft_legacy #4024

Merged
merged 3 commits into from
Jan 29, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jan 27, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

This PR allows --verbose and -v to be used when building core18|20 snaps.

Support for other verbosity options (-q, --quiet, --verbosity=<verbosity level>) can be added in the same manner.

(CRAFT-1292)

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #4024 (8c4f929) into main (88fbd5b) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4024   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          78       78           
  Lines        5192     5192           
=======================================
  Hits         4761     4761           
  Misses        431      431           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal marked this pull request as draft January 27, 2023 15:59
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal marked this pull request as ready for review January 27, 2023 22:32
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@sergiusens sergiusens merged commit be005b9 into canonical:main Jan 29, 2023
@mr-cal mr-cal deleted the cli-verbose-flag branch January 30, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants