Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy _deb: Add option to specify packages to unmark #4026

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Feb 3, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@artivis
Copy link
Contributor Author

artivis commented Feb 3, 2023

Note: black complains about files that are not concerned by this PR.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #4026 (eda7979) into main (11aaab5) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head eda7979 differs from pull request most recent head 89152e8. Consider uploading reports for the commit 89152e8 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #4026      +/-   ##
==========================================
- Coverage   91.75%   91.69%   -0.06%     
==========================================
  Files          79       78       -1     
  Lines        5302     5192     -110     
==========================================
- Hits         4865     4761     -104     
+ Misses        437      431       -6     
Impacted Files Coverage Δ
snapcraft/commands/extensions.py 98.11% <0.00%> (-1.89%) ⬇️
snapcraft/elf/elf_utils.py 93.65% <0.00%> (-1.74%) ⬇️
snapcraft/commands/discovery.py 90.69% <0.00%> (-0.80%) ⬇️
snapcraft/extensions/registry.py 90.00% <0.00%> (-0.48%) ⬇️
snapcraft/utils.py 91.42% <0.00%> (-0.05%) ⬇️
snapcraft/elf/_elf_file.py 97.21% <0.00%> (ø)
snapcraft/linters/linters.py 97.59% <0.00%> (ø)
snapcraft/parts/lifecycle.py 88.58% <0.00%> (ø)
snapcraft/extensions/kde_neon.py
snapcraft/linters/library_linter.py 87.23% <0.00%> (+1.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

artivis added 3 commits March 1, 2023 14:37
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis force-pushed the feature/apt_ignore branch from 3598cbc to 89152e8 Compare March 1, 2023 13:38
@sergiusens sergiusens merged commit d4cc135 into canonical:main Mar 1, 2023
@artivis artivis deleted the feature/apt_ignore branch March 1, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants