Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: reformat for black 23.1.0 #4029

Merged
merged 1 commit into from
Feb 7, 2023
Merged

lint: reformat for black 23.1.0 #4029

merged 1 commit into from
Feb 7, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Feb 6, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Updates for black 2023 changes

@mr-cal
lint: reformat for black 23.1.0
c20d166 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
cmatsuoka
cmatsuoka approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mr-cal mr-cal enabled auto-merge (squash) February 6, 2023 22:15
@mr-cal
Copy link
Collaborator Author

mr-cal commented Feb 7, 2023

The only failure is a unit test failure due to using setuptools>=66. This is causing failures on all open PRs, so I'm merging in this PR and opening another PR for fixing setuptools.

@mr-cal mr-cal disabled auto-merge February 7, 2023 18:25
@mr-cal mr-cal merged commit 51c2494 into canonical:main Feb 7, 2023
@mr-cal mr-cal deleted the black-2023 branch February 7, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-cal @cmatsuoka