Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: log envvar SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT when invalid #4041

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Feb 23, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

No functional changes.

Minor logging improvement to log the environment variable SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT when it is invalid.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the parallel-build-count branch from 5489261 to cea11b3 Compare February 23, 2023 17:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #4041 (5489261) into main (ce9c24e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5489261 differs from pull request most recent head cea11b3. Consider uploading reports for the commit cea11b3 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4041   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          78       78           
  Lines        5230     5231    +1     
=======================================
+ Hits         4795     4796    +1     
  Misses        435      435           
Impacted Files Coverage Δ
snapcraft/utils.py 91.47% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens merged commit 1f8bef6 into canonical:main Feb 23, 2023
@mr-cal mr-cal deleted the parallel-build-count branch February 23, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants