Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update deprecated node12-based actions #4047

Merged
merged 1 commit into from
Mar 1, 2023
Merged

ci: update deprecated node12-based actions #4047

merged 1 commit into from
Mar 1, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Mar 1, 2023

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@lengau lengau marked this pull request as ready for review March 1, 2023 04:45
@lengau lengau requested a review from tigarmo March 1, 2023 04:46
tigarmo
tigarmo approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tigarmo
Copy link
Contributor

tigarmo commented Mar 1, 2023

I'm afraid I can't merge this:
image

@sergiusens sergiusens merged commit 00540b4 into canonical:main Mar 1, 2023
@lengau lengau deleted the nodejs-12-deprecated branch March 1, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @tigarmo @sergiusens