Merge 7.3 hotfixes #4066
Merged
Merge 7.3 hotfixes #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4054) Core22 ROS 2 colcon snaps couldn't build packages creating custom ROS 2 interfaces. It was sourcing the environment before downloading the dependencies. Some dependencies (rosidl) have specificities when sourced, hence sourcing before downloading them causes issues. In the case of ROS 2 message, the PYTHONPATH only had the site-packages subdir and not the dist-packages subdir added by rosidl. This issue couldn't appear with lxd spread tests because the lxd environment was not cleaned properly by colcon spread tests (Debian packages were still installed, hence the dependencies were mostly already installed). Additionally, the advanced colcon spread tests had no entry in the spread.yaml and were never called. Hence, this code: - Adds missing spread entry for colcon specific tests - Adds package-utils.sh to restore the state of Debian package installed before a spread tests - Adds a colcon spread test with a message package to highlight that there is a bug - Fixes the bug by sourcing the ROS 2 environment after installing the ROS 2 dependencies Co-authored-by: Guillaume Beuzeboc <guillaume.beuzeboc@canonical.com>
- moved back to the full blown command-chain for KDE Neon - removed dependency on bindtextdomain - updated the pattern match for kde sdk snaps - tests updated to conside core22 - fixed the added part names Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
mr-cal
approved these changes
Mar 10, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4066 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 641 641
Lines 51772 51769 -3
=======================================
Hits 48972 48972
+ Misses 2800 2797 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?