Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kde content snap version and update regex to reflect change. #4069

Merged

Conversation

ScarlettGatelyMoore
Copy link
Contributor

  • [ x] Have you followed the guidelines for contributing?
  • [x ] Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@sergiusens
Copy link
Collaborator

looks good, run black to reformat and get rid of the linter errors

@ScarlettGatelyMoore
Copy link
Contributor Author

Linters and spread tests fixed, I also had to make a few changes as noted in the commit messages. The last few failing spread tests I can't sort out and seem unrelated ? Please let me know. Thank you

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #4069 (3c81696) into main (71ed1a3) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4069   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files         641      641           
  Lines       51903    51903           
=======================================
  Hits        49107    49107           
  Misses       2796     2796           
Impacted Files Coverage Δ
tests/unit/extensions/test_kde_neon.py 100.00% <ø> (ø)
snapcraft/extensions/kde_neon.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ScarlettGatelyMoore
Copy link
Contributor Author

Linters and spread tests fixed, I also had to make a few changes as noted in the commit messages. The last few failing spread tests I can't sort out and seem unrelated ? Please let me know. Thank you

looks good, run black to reformat and get rid of the linter errors

Ok, all tests now pass.

@sergiusens sergiusens enabled auto-merge (squash) March 25, 2023 21:27
@sergiusens sergiusens merged commit 0b95d4c into canonical:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants