-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kde content snap version and update regex to reflect change. #4069
Update kde content snap version and update regex to reflect change. #4069
Conversation
looks good, run black to reformat and get rid of the linter errors |
Move to $CRAFT from $SNAPCRAFT, update build-environment test value for cmake.
Add back cmake arg bits, add build-snaps to parts snippets.
…on kde-neon/sdk claiming invalid part name by removing trailing /sdk ( tested and this fixes issue )
Linters and spread tests fixed, I also had to make a few changes as noted in the commit messages. The last few failing spread tests I can't sort out and seem unrelated ? Please let me know. Thank you |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4069 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 641 641
Lines 51903 51903
=======================================
Hits 49107 49107
Misses 2796 2796
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…will file bug with snapcaft remote-build
Ok, all tests now pass. |
make lint
?pytest tests/unit
?