projects: warn on "global" assign of plugs and slots #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4097 +/- ##
==========================================
- Coverage 94.62% 94.61% -0.01%
==========================================
Files 643 643
Lines 52037 52036 -1
==========================================
- Hits 49238 49235 -3
- Misses 2799 2801 +2
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tigarmo
force-pushed
the
CRAFT-1692-warn-toplevel-plug
branch
from
3f3ce77 to
f11d2f9
Compare
tigarmo
commented
Apr 17, 2023
This commit adds a warning (via emit.message()) when a snapcraft.yaml project has top-level plugs and/or slots that are used for assignment and not per-plug/slot configuration. Thanks to lucyllewy for suggested wording of the warning.
tigarmo
force-pushed
the
CRAFT-1692-warn-toplevel-plug
branch
from
f11d2f9 to
acd2eb0
Compare
|
Reword "Plugs should be assigned to the app that they apply ..." to "Plugs should be assigned to the app to which they apply ..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a warning (via emit.message()) when a snapcraft.yaml project has top-level plugs and/or slots that are used for assignment and not per-plug/slot configuration. Thanks to lucyllewy for suggested wording of the warning.
make lint?pytest tests/unit?