Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros: remove generator warnings from linter spread tests #4202

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

cmatsuoka
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
@cmatsuoka cmatsuoka requested a review from mr-cal June 6, 2023 12:30
@cmatsuoka
Copy link
Contributor Author

@artivis, please leave a comment if you think this is incorrect.

@artivis
Copy link
Contributor

artivis commented Jun 6, 2023

Actually not sure what's going on here (with respect to #4184). Friendly ping @Guillaumebeuzeboc .

@Guillaumebeuzeboc
Copy link
Contributor

Actually not sure what's going on here (with respect to #4184). Friendly ping @Guillaumebeuzeboc .

Was the linter updated?

@cmatsuoka
Copy link
Contributor Author

The linter was not changed AFAIK (but @mr-cal can confirm this), any recent changes in the ROS libraries?

@mr-cal
Copy link
Collaborator

mr-cal commented Jun 6, 2023

The linter was not changed AFAIK (but @mr-cal can confirm this), any recent changes in the ROS libraries?

No changes to our linters, so a change to the ROS library or its dependencies is the likely cause.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. - This is the 3rd time this has failed (1 and 2). At some point, we should consider a less hard-coded way to test this.

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #4202 (ea38379) into main (530ad01) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4202   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files         569      569           
  Lines       43746    43746           
=======================================
  Hits        41078    41078           
  Misses       2668     2668           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal merged commit d48db22 into canonical:main Jun 6, 2023
mr-cal pushed a commit that referenced this pull request Jun 6, 2023
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka added a commit to cmatsuoka/snapcraft that referenced this pull request Jun 15, 2023
mr-cal pushed a commit that referenced this pull request Jun 15, 2023
This was referenced Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants