Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): use craft-application from main branch #4573

Merged
merged 6 commits into from
Feb 14, 2024
Merged

build(deps): use craft-application from main branch #4573

merged 6 commits into from
Feb 14, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Feb 12, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@lengau lengau force-pushed the CRAFT-2486/craft-application-main branch from 982795d to b360ba8 Compare February 12, 2024 20:02
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024 •
edited
Loading

Codecov Report

Attention: 284 lines in your changes are missing coverage. Please review.

Comparison is base (51dd2c6) 88.33% compared to head (7936d72) 88.02%.
Report is 11 commits behind head on feature/craft-application.

❗ Current head 7936d72 differs from pull request most recent head 25f9205. Consider uploading reports for the commit 25f9205 to get more accurate results

Files Patch % Lines
snapcraft/application.py 0.00% 120 Missing ⚠️
snapcraft/commands/unimplemented.py 0.00% 106 Missing ⚠️
snapcraft/services/package.py 0.00% 33 Missing ⚠️
snapcraft/models/project.py 69.69% 10 Missing ⚠️
snapcraft/services/service_factory.py 0.00% 9 Missing ⚠️
snapcraft/services/__init__.py 0.00% 4 Missing ⚠️
snapcraft/__main__.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@                      Coverage Diff                      @@
##           feature/craft-application    #4573      +/-   ##
=============================================================
- Coverage                      88.33%   88.02%   -0.31%     
=============================================================
  Files                            327      327              
  Lines                          21961    22027      +66     
=============================================================
- Hits                           19399    19390       -9     
- Misses                          2562     2637      +75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sergiusens
sergiusens reviewed Feb 13, 2024
View reviewed changes
snapcraft/application.py

APP_METADATA = AppMetadata(
name="snapcraft",
summary="Package, distribute, and update snaps for Linux and IoT",
ProjectClass=models.Project,
BuildPlannerClass=SnapcraftBuildPlanner,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like we need an AppSolver or similar now. Just a thought.

@cmatsuoka ?

@sergiusens
Copy link
Collaborator

looks pretty good, seems there is some curation left to comply with the linters

@lengau lengau requested review from sergiusens and mr-cal February 13, 2024 17:12
mr-cal
mr-cal approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mr-cal
mr-cal approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to submit my comment

snapcraft/application.py Show resolved Hide resolved
@lengau @sergiusens
fix: pr suggestions
6c7e3cc 
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@lengau lengau requested a review from sergiusens February 14, 2024 19:11
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/craft-application@cc5c6fa). Click here to learn what that means.

Additional details and impacted files 
@@                     Coverage Diff                      @@
##             feature/craft-application    #4573   +/-   ##
============================================================
  Coverage                             ?   88.04%           
============================================================
  Files                                ?      328           
  Lines                                ?    22076           
  Branches                             ?        0           
============================================================
  Hits                                 ?    19437           
  Misses                               ?     2639           
  Partials                             ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiusens sergiusens merged commit 1366eff into feature/craft-application Feb 14, 2024
8 of 10 checks passed
@sergiusens sergiusens deleted the CRAFT-2486/craft-application-main branch February 14, 2024 19:47
@lengau lengau mentioned this pull request Feb 15, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@sergiusens sergiusens sergiusens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lengau @codecov-commenter @sergiusens @mr-cal