Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): expect the proper libpng version in core24 linter test #4597

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Feb 21, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

This fixes google:ubuntu-22.04-64:tests/spread/core24/linters/library-unused

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ff3e0b) 88.83% compared to head (6ee45c6) 88.90%.
Report is 10 commits behind head on feature/craft-application.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/craft-application    #4597      +/-   ##
=============================================================
+ Coverage                      88.83%   88.90%   +0.06%     
=============================================================
  Files                            327      331       +4     
  Lines                          22033    22115      +82     
=============================================================
+ Hits                           19573    19661      +88     
+ Misses                          2460     2454       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiusens sergiusens requested a review from tigarmo February 21, 2024 19:07
@sergiusens sergiusens merged commit 4f08e74 into feature/craft-application Feb 21, 2024
7 of 10 checks passed
@sergiusens sergiusens deleted the CRAFT-2471-png-linter branch February 21, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants