fix: update to craft-application latest #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Create a default build plan with a build info matching the host's architecture and base, so that individual plan-dependent tests don't have to worry about tweaking the plan.
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/craft-application #4659 +/- ##
=============================================================
+ Coverage 89.14% 89.22% +0.07%
=============================================================
Files 331 334 +3
Lines 22078 22277 +199
=============================================================
+ Hits 19682 19876 +194
- Misses 2396 2401 +5 ☔ View full report in Codecov by Sentry. |
sergiusens
approved these changes
Mar 13, 2024
|
Spread test failures look as expected to me. The only "new" failure I noticed is that |
tigarmo
approved these changes
Mar 13, 2024
|
@sergiusens - can you land this? |
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)#4616, #4643, and #4651 all accommodate for different breaking changes in craft-application's main branch.
This PR has a commit for each of those PRs.