Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate installed_base_by_architecture metrics #4735

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

DanielDewberry
Copy link
Contributor

Pursuant to my post on Discourse
(https://forum.snapcraft.io/t/enable-by-architecture-in-the-snapcraft-metrics-cli-tooling/39750), this commit activates the installed_base_by_architecture and weekly_installed_base_by_architecture metrics in the snapcraft metrics tool.

The metric was previously introduced according to this PR canonical/snapcraft.io#1680 (comment)

A subsequent issue will be raised against the documentation.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@DanielDewberry
Copy link
Contributor Author

I signed the CLA last night with the email address on my Snapcraft account.
I've just signed it again with the email on the commits. My Launchpad & Snapcraft accounts are dwd-daniel

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for the contribution!

@mr-cal
Copy link
Collaborator

mr-cal commented Apr 16, 2024

PS - I just added these to this documentation page

@DanielDewberry
Copy link
Contributor Author

Works great, thanks for the contribution!

Thank you very much :)

PS - I just added these to this documentation page

Thank you, that's great!

@DanielDewberry
Copy link
Contributor Author

@mr-cal How should we proceed with regard to the failing CLA check? I have signed it with both the email address on the commit and the email address on my Launchpad account.

@mr-cal
Copy link
Collaborator

mr-cal commented Apr 16, 2024

Checking the following users on GitHub:
Check in the signed list service
Error occurred while checking user: Request failed with status code 404

It looks like this problem with the github action: canonical/has-signed-canonical-cla#37.

@sergiusens - How should we proceed?

@sergiusens
Copy link
Collaborator

The 404 is a result of the query. This should be fine to merge in anyways without waiting. but we can retry later and if it does not work I can go and track the systems responsible for the data.

@DanielDewberry
Copy link
Contributor Author

Thank you both

@DanielDewberry
Copy link
Contributor Author

The 404 is a result of the query. This should be fine to merge in anyways without waiting. but we can retry later and if it does not work I can go and track the systems responsible for the data.

@mr-cal @sergiusens Do you need me to do/confirm anything?

@mr-cal
Copy link
Collaborator

mr-cal commented Apr 22, 2024

@sergiusens - Can you override and merge?

Pursuant to my post on Discourse
(https://forum.snapcraft.io/t/enable-by-architecture-in-the-snapcraft-metrics-cli-tooling/39750),
this commit activates the installed_base_by_architecture and weekly_installed_base_by_architecture
metrics in the snapcraft metrics tool.

The metric was previously introduced according to this PR
canonical/snapcraft.io#1680 (comment)

A subsequent issue will be raised against the documentation.
@DanielDewberry DanielDewberry force-pushed the DWD-Metrics-Architecture branch from 5de27cf to ada09ba Compare April 23, 2024 14:03
@mr-cal
Copy link
Collaborator

mr-cal commented Apr 24, 2024

I'll get this landed on Friday or early next week, after we ship snapcraft 8.2.1.

@DanielDewberry
Copy link
Contributor Author

I'll get this landed on Friday or early next week, after we ship snapcraft 8.2.1.

Thank you

@mr-cal
Copy link
Collaborator

mr-cal commented Apr 29, 2024

Override-merging because CLA has been signed.

@mr-cal mr-cal merged commit b712a84 into canonical:main Apr 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants