Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update grammar models #4746

Closed
wants to merge 2 commits into from
Closed

refactor: update grammar models #4746

wants to merge 2 commits into from

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Apr 18, 2024

"GrammarStr" becomes "Grammar[str]", and so on.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (6ff73a1) to head (d25b0c4).
Report is 37 commits behind head on main.

❗ Current head d25b0c4 differs from pull request most recent head 862ce34. Consider uploading reports for the commit 862ce34 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4746      +/-   ##
==========================================
+ Coverage   89.54%   89.58%   +0.04%     
==========================================
  Files         337      332       -5     
  Lines       22638    22104     -534     
==========================================
- Hits        20271    19802     -469     
+ Misses       2367     2302      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"GrammarStr" becomes "Grammar[str]", and so on.
@mr-cal
Copy link
Collaborator

mr-cal commented Oct 7, 2024

Closing because this has been completed via the pydantic 2 refactor: #4955

@mr-cal mr-cal closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants