Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set project variables for core24 #4757

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 24, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Set project variables for core24 snaps.

CRAFT_PROJECT_NAME and CRAFT_PROJECT_VERSION are not set, see canonical/craft-application#320 for details.

Fixes #4704
Fixes #4702
(CRAFT-2657)
(CRAFT-2655)

mr-cal added 2 commits April 24, 2024 08:01
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-2657-core24-project-variables branch from 3c8303f to 9fb6476 Compare April 24, 2024 13:01
@mr-cal mr-cal requested review from tigarmo and lengau April 24, 2024 16:00
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@mr-cal mr-cal enabled auto-merge (squash) April 24, 2024 18:45
@mr-cal mr-cal merged commit 2795751 into hotfix/8.2 Apr 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants