Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove core24 snap workarounds #4761

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 25, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Drop core24 workarounds in the spread tests.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (hotfix/8.2@b8ff64b). Click here to learn what that means.

❗ Current head a4b8ac4 differs from pull request most recent head 73b508e. Consider uploading reports for the commit 73b508e to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             hotfix/8.2    #4761   +/-   ##
=============================================
  Coverage              ?   89.58%           
=============================================
  Files                 ?      331           
  Lines                 ?    22091           
  Branches              ?        0           
=============================================
  Hits                  ?    19790           
  Misses                ?     2301           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-cal mr-cal force-pushed the work/core24-release branch from a4b8ac4 to 6fb50cb Compare April 25, 2024 23:34
@mr-cal mr-cal requested review from tigarmo and mattculler April 26, 2024 13:29
@mr-cal mr-cal mentioned this pull request Apr 26, 2024
4 tasks
@mr-cal mr-cal changed the base branch from main to hotfix/8.2 April 26, 2024 15:35
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/core24-release branch from 6fb50cb to 73b508e Compare April 26, 2024 15:36
@mr-cal
Copy link
Collaborator Author

mr-cal commented Apr 26, 2024

Retargeting hotfix/8.2 because I need CI to pass on that branch today.

@mr-cal mr-cal enabled auto-merge (squash) April 26, 2024 16:33
@mr-cal mr-cal merged commit 7cdd9b0 into hotfix/8.2 Apr 26, 2024
9 of 10 checks passed
mr-cal added a commit that referenced this pull request Apr 26, 2024
Drop core24 workarounds in the spread tests now that `core24` is available on stable.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal added a commit that referenced this pull request Apr 29, 2024
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants