Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not load system libraries for classic core24 snaps, bump craft-parts, unregister dotnet #4809

Merged
merged 3 commits into from
May 17, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented May 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

This PR has 3 commits for snapcraft 8.2.8.

Replacement PR for #4807

Commits:

  • On core24, snapcraft should pass --no-default-libs to patchelf to not load libraries from default locations for classic snaps.
  • Bump craft parts
  • Unregister dotnet for core24

@mr-cal mr-cal force-pushed the work/patchelf-no-default-libs branch 5 times, most recently from 2f8d75a to 6b300c7 Compare May 16, 2024 10:38
@mr-cal mr-cal changed the title fix: do not load system libraries for classic core24 snaps do not load system libraries for classic core24 snaps, bump craft-parts, unregister dotnet May 16, 2024
@mr-cal mr-cal added the rebase label May 16, 2024
mr-cal added 3 commits May 16, 2024 12:39
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
The dotnet plugin is going to be redesigned for core24.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/patchelf-no-default-libs branch from 6b300c7 to d9f9b22 Compare May 16, 2024 10:40
@mr-cal mr-cal added the squash label May 16, 2024
@mr-cal mr-cal requested review from tigarmo, cmatsuoka and lengau May 16, 2024 12:37
@lengau lengau requested review from dariuszd21 and mattculler May 17, 2024 07:28
@mr-cal mr-cal merged commit c4e2f23 into hotfix/8.2 May 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants