Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn when multiple snaps will be built in the same environment #4839

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 4, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Warn when multiple snaps will be built in the same environment for core22 snaps.

Fixes #4685
Fixes #4356
(CRAFT-2627)

mr-cal added 2 commits June 4, 2024 08:09
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Core22 allows for building multiple snaps in the same build environment,
which can cause unexpected behavior.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested review from tigarmo, lengau and cmatsuoka and removed request for lengau June 4, 2024 14:24
snapcraft/parts/lifecycle.py Outdated Show resolved Hide resolved
@mr-cal mr-cal removed the request for review from cmatsuoka June 5, 2024 13:42
@mr-cal mr-cal merged commit 67de408 into main Jun 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants