Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): forward proxy variables to core24 build environments #4973

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix(provider): forward proxy variables to core24 build environments #4973

merged 2 commits into from
Aug 15, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Aug 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)
  • Forward http_proxy, https_proxy, and no_proxy into core24 build environments
  • Add a regression test
  • Bump craft-application to 4.1.0

@mr-cal mr-cal added the rebase label Aug 15, 2024
@mr-cal mr-cal requested review from lengau and a team August 15, 2024 15:50
@mr-cal mr-cal requested a review from a team August 15, 2024 16:10
mr-cal added 2 commits August 15, 2024 13:58
@mr-cal @lengau
build(deps): bump craft-application to 4.1.0
0718d61 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal @lengau
fix(provider): forward proxy variables to core24 build environments
b14e3b9 
Forward `http_proxy`, `https_proxy`, and `no_proxy` to core24 build
environments.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@lengau lengau force-pushed the work/provider-service-fix branch from bd471c0 to b14e3b9 Compare August 15, 2024 17:58
@lengau lengau enabled auto-merge (rebase) August 15, 2024 18:23
@lengau lengau merged commit 28da125 into main Aug 15, 2024
10 checks passed
@mr-cal mr-cal mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @tigarmo @lengau