Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remotebuild): parse comma-separated architectures #5028

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 11, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Allow comma-separated values for --build-for and --platform.

Remote build spread tests are successful: https://github.com/canonical/snapcraft/actions/runs/10814283451/job/30000756052

Fixes #4990
(CRAFT-3271)

@mr-cal mr-cal force-pushed the work/CRAFT-3271/remote-build-csv branch from 5e77db7 to 5bdb61f Compare September 11, 2024 18:10
@mr-cal mr-cal changed the base branch from main to hotfix/8.4 September 11, 2024 18:25
@mr-cal mr-cal requested review from lengau and mattculler September 11, 2024 18:49
snapcraft/commands/remote.py Outdated Show resolved Hide resolved
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-3271/remote-build-csv branch from 8fef095 to a6778ea Compare September 13, 2024 14:49
@mr-cal mr-cal enabled auto-merge (rebase) September 13, 2024 14:49
@mr-cal mr-cal merged commit 12b70e7 into hotfix/8.4 Sep 13, 2024
8 of 10 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3271/remote-build-csv branch September 13, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote build: Allow comma-separated values for --build-for and --platform
3 participants