Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] chore(merge): 8.3.4 into merge/8.3.4 #5037

Closed
wants to merge 3 commits into from
Closed

[draft] chore(merge): 8.3.4 into merge/8.3.4 #5037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a24dc3e
build(deps): bump craft-parts (#5031)
tigarmo Sep 13, 2024
de055bc
chore(merge): 8.3.4 into merge/8.3.4
mr-cal Sep 13, 2024
25f5b11
docs(changelog): add 8.3.4 release notes
mr-cal Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions docs/reference/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,22 @@ Changelog

For a complete list of commits, check out the `X.Y.Z`_ release on GitHub.

8.3.4 (2024-Sep-13)
-------------------

Core
====

Plugins
#######

NPM
"""

* Fix a bug where NPM parts fail to build if the ``pull`` and ``build`` steps
did not occur in the same execution of Snapcraft.

For a complete list of commits, check out the `8.3.4`_ release on GitHub.

8.4.0 (2024-Sep-10)
-------------------
Expand Down Expand Up @@ -1171,4 +1187,5 @@ For a complete list of commits, check out the `8.0.0`_ release on GitHub.
.. _8.3.1: https://github.com/canonical/snapcraft/releases/tag/8.3.1
.. _8.3.2: https://github.com/canonical/snapcraft/releases/tag/8.3.2
.. _8.3.3: https://github.com/canonical/snapcraft/releases/tag/8.3.3
.. _8.3.4: https://github.com/canonical/snapcraft/releases/tag/8.3.4
.. _8.4.0: https://github.com/canonical/snapcraft/releases/tag/8.4.0
3 changes: 3 additions & 0 deletions tests/spread/core24/npm-reentrant/hello.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env node

console.log('hello world');
5 changes: 5 additions & 0 deletions tests/spread/core24/npm-reentrant/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions tests/spread/core24/npm-reentrant/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"name": "npm-hello",
"version": "1.0.0",
"description": "Testing grounds for snapcraft integration tests",
"bin": {
"npm-hello": "hello.js"
},
"scripts": {
"npm-hello": "echo \"Error: no test specified\" && exit 1"
},
"author": "",
"license": "GPL-3.0"
}
15 changes: 15 additions & 0 deletions tests/spread/core24/npm-reentrant/snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: npm-reentrant
version: "1.0"
summary: test the npm plugin
description: Check that the npm plugin works across snapcraft calls

confinement: strict
grade: devel
base: core24

parts:
hello:
source: .
plugin: npm
npm-include-node: true
npm-node-version: 22.1.0
11 changes: 11 additions & 0 deletions tests/spread/core24/npm-reentrant/task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
summary: Pull, then Build, a Node snap

execute: |
snapcraft pull
snapcraft build
snapcraft pack
test -f npm-reentrant*.snap

restore: |
snapcraft clean
rm -f ./*.snap
Loading