Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: there is now the official repo with images #5063

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

abitrolly
Copy link
Contributor

https://github.com/canonical/snapcraft-rocks/

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (654871d) to head (a299b75).
Report is 585 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (a299b75). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (a299b75)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5063      +/-   ##
==========================================
- Coverage   94.88%   89.67%   -5.21%     
==========================================
  Files         658      340     -318     
  Lines       55189    22546   -32643     
==========================================
- Hits        52364    20219   -32145     
+ Misses       2825     2327     -498     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docker/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
@abitrolly
Copy link
Contributor Author

@tigarmo no problem. I am itching my own itches. )

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mr-cal mr-cal merged commit 24e70d6 into canonical:main Oct 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants