Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kde-neon-6 to schema #5127

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

pedro-avalos
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Addresses #5126

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (654871d) to head (50b124e).
Report is 619 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5127      +/-   ##
==========================================
- Coverage   94.88%   89.71%   -5.17%     
==========================================
  Files         658      342     -316     
  Lines       55189    22640   -32549     
==========================================
- Hits        52364    20312   -32052     
+ Misses       2825     2328     -497     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mr-cal mr-cal requested a review from a team October 18, 2024 12:39
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mr-cal mr-cal added the squash label Oct 18, 2024
@lengau lengau enabled auto-merge (squash) October 21, 2024 00:26
@mr-cal
Copy link
Collaborator

mr-cal commented Oct 21, 2024

CI is broken, closing and reopening to rerun everything

@mr-cal mr-cal closed this Oct 21, 2024
auto-merge was automatically disabled October 21, 2024 14:18

Pull request was closed

@mr-cal mr-cal reopened this Oct 21, 2024
@mr-cal mr-cal enabled auto-merge (squash) October 21, 2024 14:19
@mr-cal mr-cal merged commit b695411 into canonical:main Oct 21, 2024
22 of 25 checks passed
@pedro-avalos pedro-avalos deleted the add-kde-neon-6-to-schema branch October 21, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants