many: rename registry role s/manager/custodian

Signed-off-by: Miguel Pires <miguel.pires@canonical.com>

interfaces/builtin/registry.go

@@ -70,10 +70,10 @@ func (iface *registryInterface) BeforePreparePlug(plug *snap.PlugInfo) error {
 	}
 
 	// by default, snaps can read/write registries and be notified of changes. The
-	// manager role allows snaps to change, reject and persist changes made by others
+	// custodian role allows snaps to change, reject and persist changes made by others
 	role, ok := plug.Attrs["role"].(string)
-	if ok && role != "manager" {
-		return fmt.Errorf(`optional registry plug "role" attribute must be "manager"`)
+	if ok && role != "custodian" {
+		return fmt.Errorf(`optional registry plug "role" attribute must be "custodian"`)
 	}
 
 	return nil

interfaces/builtin/registry_test.go

@@ -92,7 +92,7 @@ func (s *registrySuite) TestRegistrySanitizePlug(c *C) {
 		{
 			account: "my-acc",
 			view:    "network/wifi",
-			role:    "manager",
+			role:    "custodian",
 		},
 		{
 			account: "my-acc",
@@ -109,7 +109,7 @@ func (s *registrySuite) TestRegistrySanitizePlug(c *C) {
 			account: "my-acc",
 			view:    "reg/view",
 			role:    "observer",
-			err:     `optional registry plug "role" attribute must be "manager"`,
+			err:     `optional registry plug "role" attribute must be "custodian"`,
 		},
 		{
 			account: "my-acc",

overlord/hookstate/ctlcmd/get_test.go

@@ -557,7 +557,7 @@ plugs:
     interface: registry
     account: %[1]s
     view: network/write-wifi
-    role: manager
+    role: custodian
 `, s.devAccID)
 	info := mockInstalledSnap(c, s.state, snapYaml, "")
 

snap/info_test.go

@@ -2425,7 +2425,7 @@ func (s *infoSuite) TestRegistryPlugAttrs(c *C) {
 		Attrs: map[string]interface{}{
 			"account": "foo",
 			"view":    "bar/baz",
-			"role":    "manager",
+			"role":    "custodian",
 		},
 	}