Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fixes for fde and devmode-snap-seeded-dangerous nested tests #14301

Merged

Conversation

sergiocazzolato
Copy link
Collaborator

This change:

  1. renames models used for fde tests
  2. fix devmode-snap-seeded-dangerous
  3. adapt some nested tests to run in uc24

@github-actions github-actions bot added the Run Nested -auto- Label automatically added in case nested tests need to be executed label Aug 2, 2024
@sergiocazzolato sergiocazzolato added Run nested The PR also runs tests inluded in nested suite and removed Run Nested -auto- Label automatically added in case nested tests need to be executed labels Aug 2, 2024
@github-actions github-actions bot added the Run Nested -auto- Label automatically added in case nested tests need to be executed label Aug 2, 2024
@sergiocazzolato sergiocazzolato force-pushed the tests-more-nested-fixes-uc branch from 82fa7ce to 2b7abcc Compare August 7, 2024 13:38
Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing

tests/lib/assertions/classic-model-24.assert Outdated Show resolved Hide resolved
Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@valentindavid valentindavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. Thank you.

@sergiocazzolato sergiocazzolato merged commit 18a9ada into canonical:master Aug 9, 2024
49 of 53 checks passed
@sergiocazzolato sergiocazzolato deleted the tests-more-nested-fixes-uc branch August 9, 2024 17:57
zyga pushed a commit to zyga/snapd that referenced this pull request Aug 13, 2024
…anonical#14301)

* tests: fixes for fde and devmode-snap-seeded-dangerous nested tests

This change renames models used for fde tests
Also adapt some nested tests to run in uc24

* revert change related to ubuntu-seed

* fix shellcheck errors

* more fixes for boot dir

* remove support for uc24 on fde-on-classic test

* fix hybrid-remodel test

the test still fails because of this issue
https://paste.ubuntu.com/p/gZvZRtvjTz/

* updating classic models to use pc-kernel from beta by default

* download 23.10 pc snap for uc22 in hybrid-remodel test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Nested -auto- Label automatically added in case nested tests need to be executed Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants