Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: added dependabot for updating dependencies #14579

Merged

Conversation

maykathm
Copy link
Contributor

@maykathm maykathm commented Oct 7, 2024

When merged to master, dependabot will check for updates in go dependencies and github actions weekly. When it finds an out-of-date package, it will automatically open a pull request. Here's an example of the pull requests opened on my fork of snapd when I pushed this yaml file to master: https://github.com/maykathm/snapd/pulls

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (25236db) to head (2159e04).
Report is 202 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14579      +/-   ##
==========================================
+ Coverage   78.86%   80.15%   +1.28%     
==========================================
  Files        1083     1160      +77     
  Lines      146105   162210   +16105     
==========================================
+ Hits       115233   130024   +14791     
- Misses      23675    24755    +1080     
- Partials     7197     7431     +234     
Flag Coverage Δ
unittests 80.15% <ø> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maykathm maykathm marked this pull request as draft October 8, 2024 10:33
@maykathm
Copy link
Contributor Author

maykathm commented Oct 8, 2024

It looks like the dependabot will only send alerts for security updates. One option to keep the number of pull requests down is to group the changes.

Here's an example where I had the bot group together:

To ignore an update, one would have to either issue a command like @dependabot ignore <dep-name> major version or add that ignore command to the dependabot.yaml file. The bot doesn't automatically update the pull request though so ignores would need to be followed by an additional manual commit.

Obviously one can also change the frequency of updates. I currently have it set to weekly.

What do you think @ernestl and @sergiocazzolato?

Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

  • Lets discuss with the team to get consensus on interval and grouping.
  • Once fix cadence releases become a thing, we can consider doing this at a date right after such a release to ensure maximum time between updates and release attempts.

@ernestl ernestl added Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run ⛔ Blocked labels Oct 10, 2024
@ernestl
Copy link
Collaborator

ernestl commented Oct 14, 2024

Blocked, decided to first discuss with the team during engineering sprint.

@maykathm maykathm marked this pull request as ready for review December 5, 2024 07:58
Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should merge it as it will only open PRs and not automatically update anything. I'm not aware of any downsides.

@maykathm maykathm closed this Dec 5, 2024
@maykathm maykathm reopened this Dec 5, 2024
Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ernestl ernestl merged commit 0268f05 into canonical:master Dec 5, 2024
99 of 115 checks passed
@maykathm maykathm deleted the SNAPDENG-32544-setup-dependabot-for-snapd branch December 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants