-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: added dependabot for updating dependencies #14579
tests: added dependabot for updating dependencies #14579
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14579 +/- ##
==========================================
+ Coverage 78.86% 80.15% +1.28%
==========================================
Files 1083 1160 +77
Lines 146105 162210 +16105
==========================================
+ Hits 115233 130024 +14791
- Misses 23675 24755 +1080
- Partials 7197 7431 +234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It looks like the dependabot will only send alerts for security updates. One option to keep the number of pull requests down is to group the changes. Here's an example where I had the bot group together:
To ignore an update, one would have to either issue a command like Obviously one can also change the frequency of updates. I currently have it set to weekly. What do you think @ernestl and @sergiocazzolato? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
- Lets discuss with the team to get consensus on interval and grouping.
- Once fix cadence releases become a thing, we can consider doing this at a date right after such a release to ensure maximum time between updates and release attempts.
Blocked, decided to first discuss with the team during engineering sprint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we should merge it as it will only open PRs and not automatically update anything. I'm not aware of any downsides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
When merged to master, dependabot will check for updates in go dependencies and github actions weekly. When it finds an out-of-date package, it will automatically open a pull request. Here's an example of the pull requests opened on my fork of snapd when I pushed this yaml file to master: https://github.com/maykathm/snapd/pulls