Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confdb,asserts,daemon: add confdb-control api #14866

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

st3v3nmw
Copy link
Contributor

This PR introduces the confdb-control API to snapd.

Please do not review just yet. Awaiting:

@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Dec 17, 2024
@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch from 1e10d53 to 983bc9d Compare December 17, 2024 10:09
@st3v3nmw st3v3nmw changed the title confdb, daemon: add confdb-control api confdb,daemon: add confdb-control api Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 96 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (24a0034) to head (1ed5ca7).
Report is 74 commits behind head on master.

Files with missing lines Patch % Lines
daemon/api_confdb.go 12.90% 54 Missing ⚠️
confdb/confdb_control.go 83.04% 24 Missing and 5 partials ⚠️
asserts/confdb.go 79.36% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14866      +/-   ##
==========================================
+ Coverage   78.20%   78.29%   +0.08%     
==========================================
  Files        1151     1150       -1     
  Lines      151396   152819    +1423     
==========================================
+ Hits       118402   119647    +1245     
- Misses      25662    25800     +138     
- Partials     7332     7372      +40     
Flag Coverage Δ
unittests 78.29% <67.56%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch from 983bc9d to ea1a5cf Compare December 18, 2024 12:53
@st3v3nmw st3v3nmw changed the title confdb,daemon: add confdb-control api confdb,asserts,daemon: add confdb-control api Dec 18, 2024
@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch 2 times, most recently from f5d9ced to 4544d41 Compare December 20, 2024 08:48
@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch from 4544d41 to 1ed5ca7 Compare December 20, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant