Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: correct snapd revision number in snapd-refresh-undo for ARM #14880

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

maykathm
Copy link
Contributor

No description provided.

Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@olivercalder olivercalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to find an arm64 snap revision close to 18357 and manually refresh to that instead if the runner arch is arm64?

@olivercalder
Copy link
Member

I believe the corresponding arm64 revision for the amd64 revision 18357 is 18363. Both are snapd version 2.58.2. The previous arm64 revision from 18357 is 18353, which is snapd version 2.58.1+git1.g7f1d30a.

I would propose we switch on $(uname -m) and if it's arm64, we refresh to revision 18363 instead, and carry on with the test.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (24a0034) to head (b29add5).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14880      +/-   ##
==========================================
+ Coverage   78.20%   78.28%   +0.07%     
==========================================
  Files        1151     1156       +5     
  Lines      151396   152552    +1156     
==========================================
+ Hits       118402   119424    +1022     
- Misses      25662    25761      +99     
- Partials     7332     7367      +35     
Flag Coverage Δ
unittests 78.28% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maykathm maykathm force-pushed the fix-snapd-refresh-undo branch from d23e186 to b29add5 Compare December 19, 2024 12:08
Copy link
Member

@olivercalder olivercalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! PR title could now use an update.

@maykathm maykathm changed the title tests: disable snapd-refresh-undo for arm tests: correct snapd revision number in snapd-refresh-undo for ARM Dec 19, 2024
@maykathm maykathm merged commit fecd0a6 into canonical:master Dec 19, 2024
59 checks passed
@maykathm maykathm deleted the fix-snapd-refresh-undo branch December 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants