-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: correct snapd revision number in snapd-refresh-undo for ARM #14880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to find an arm64 snap revision close to 18357 and manually refresh to that instead if the runner arch is arm64?
I believe the corresponding arm64 revision for the amd64 revision 18357 is 18363. Both are snapd version 2.58.2. The previous arm64 revision from 18357 is 18353, which is snapd version 2.58.1+git1.g7f1d30a. I would propose we switch on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14880 +/- ##
==========================================
+ Coverage 78.20% 78.28% +0.07%
==========================================
Files 1151 1156 +5
Lines 151396 152552 +1156
==========================================
+ Hits 118402 119424 +1022
- Misses 25662 25761 +99
- Partials 7332 7367 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d23e186
to
b29add5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great! PR title could now use an update.
No description provided.