o/hookstate/ctlcmd: make is-connected check whether the plug or slot exists #9168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fell out of some improvements I was doing to #9132, where I needed the |
stolowski
approved these changes
Aug 18, 2020
…ted-bad-plug-or-slot
…ted-bad-plug-or-slot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
snapctl is-connecteddoesn't distinguish between non-existent plugs/slots and unconnected plugs/slots. This PR instead returns an error message for non-existent name. The exit code remains the same.This makes typos in hooks and other scripts more obvious. It should not have any security implications, since a snap already knows what plugs and slots it has via
$SNAP/meta/snap.yaml.