Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly parse vlan field of VLAN interfaces #227

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: correctly parse vlan field of VLAN interfaces #227

merged 1 commit into from
Jul 30, 2024

Conversation

skatsaounis
Copy link
Collaborator

  • Parse vlan field as integer rather than string
  • Add acceptance test to check the context update of all interface types

Resolves GH: #206

@skatsaounis skatsaounis linked an issue Jul 29, 2024 that may be closed by this pull request
Modifications to VLAN interfaces crash provider #206
Closed
SK1Y101
SK1Y101 previously approved these changes Jul 29, 2024
View reviewed changes
troyanov
troyanov previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@troyanov troyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

maas/resource_maas_network_interface_vlan.go Outdated Show resolved Hide resolved
@skatsaounis skatsaounis dismissed stale reviews from troyanov and SK1Y101 via d273e55 July 30, 2024 07:50
@skatsaounis skatsaounis merged commit 3fcd4e1 into canonical:master Jul 30, 2024
8 checks passed
@skatsaounis skatsaounis deleted the fix-vlan-interface-vlan branch July 30, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyanov troyanov troyanov approved these changes

@SK1Y101 SK1Y101 Awaiting requested review from SK1Y101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modifications to VLAN interfaces crash provider
3 participants
@skatsaounis @troyanov @SK1Y101