Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple statuses and versions and add tests #137

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Feb 21, 2024

Done

  • Decoupled statuses and versions

Rationale

The current functionality requires you to provide a status query for every version. For the overhaul we want to be able to query for these independent of one another such that you can query for multiple versions and one status, for example.

QA

  • See that tests are passing

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-8817

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 92.95775% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.85%. Comparing base (cb65691) to head (33efc18).
Report is 1 commits behind head on main.

❗ Current head 33efc18 differs from pull request most recent head 689e287. Consider uploading reports for the commit 689e287 to get more accurate results

Files Patch % Lines
tests/test_routes.py 91.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   83.45%   84.85%   +1.40%     
==========================================
  Files          29       29              
  Lines        1408     1459      +51     
==========================================
+ Hits         1175     1238      +63     
+ Misses        233      221      -12     
Flag Coverage Δ
python 84.85% <92.95%> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@carkod carkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Linting is not passing though.

@mtruj013 mtruj013 merged commit 1a8d4b3 into canonical:main Feb 23, 2024
5 checks passed
@mtruj013 mtruj013 deleted the decouple-version-status branch February 23, 2024 14:39
@mtruj013 mtruj013 mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants