Add fuzzy search for packages #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carkod
force-pushed
the
fuzzy-search-packages
branch
8 times, most recently
from
3b931ac
to
10e3e8c
Compare
samhotep
approved these changes
Jun 20, 2024
samhotep
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
|
Friendly reminder to rebase :) |
mtruj013
reviewed
Jun 21, 2024
tests/test_routes.py
Outdated
| ) | ||
|
|
||
| assert filtered_cves_response.status_code == 200 | ||
| assert filtered_cves_response.json["total_results"] == 1 | ||
| assert filtered_cves_response.json["total_results"] > 1 |
There was a problem hiding this comment.
@carkod can I ask what the usefulness is of making this test less specific? We want to know that the correct number of cves are returned with this query, total results being > 1 seems like it could very easily lead to false positives here
There was a problem hiding this comment.
Well for the purposes of this feature, we have to get more than one result, but sure I can make it more specific.
carkod
force-pushed
the
fuzzy-search-packages
branch
from
3f5db8c
to
a107ae5
Compare
carkod
force-pushed
the
fuzzy-search-packages
branch
from
a107ae5
to
3bd6143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Add fuzzy search for packages:
"mysql-8.0" returns an expected result for Ubuntu 22.04 LTS.
https://ubuntu.com/security/cves?q=&package=mysql-8.0
However, "mysql" doesn't contains expected result for Ubuntu 22.04 LTS.
https://ubuntu.com/security/cves?q=&package=mysql
The same condition applies to PostgreSQL.
"postgresql-14" works.
https://ubuntu.com/security/cves?q=&package=postgresql-14
However, "postgresql" doesn't contains expected result:
https://ubuntu.com/security/cves?q=&package=postgresql
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-4755