Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #3354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix tests #3354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a37b1a
tests: add step to install ubuntu-pro-auto-attach
lucasmoura Oct 21, 2024
6175861
tests: remove aws.generic from retry auto-attach
lucasmoura Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions features/retry_auto_attach.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,19 +117,14 @@ Feature: auto-attach retries periodically on failures

Examples: ubuntu release
| release | machine_type |
| xenial | aws.generic |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-attach retries should work on aws, right? What changed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should read commit messages before commenting 🤦

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then, if the mechanism for triggering retries on aws is different now, we can't rely on the gcp/azure tests for it right?
I think we need an aws specific test for this feature now

| xenial | azure.generic |
| xenial | gcp.generic |
| bionic | aws.generic |
| bionic | azure.generic |
| bionic | gcp.generic |
| focal | aws.generic |
| focal | azure.generic |
| focal | gcp.generic |
| jammy | aws.generic |
| jammy | azure.generic |
| jammy | gcp.generic |
| noble | aws.generic |
| noble | azure.generic |
| noble | gcp.generic |

Expand Down
1 change: 1 addition & 0 deletions features/steps/ubuntu_advantage_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ def create_local_ppa(context, release):
)


@when("I install ubuntu-pro-auto-attach")
@when("I install ubuntu-advantage-pro")
def when_i_install_pro(context, machine_name=SUT):
if context.pro_config.install_from is InstallationSource.LOCAL:
Expand Down
Loading