Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update combined examples links to use correct baseline padding/margin #5324

Closed
jmuzina opened this issue Aug 23, 2024 · 1 comment · Fixed by #5327
Closed

Update combined examples links to use correct baseline padding/margin #5324

jmuzina opened this issue Aug 23, 2024 · 1 comment · Fixed by #5327

Comments

@jmuzina
Copy link
Member

jmuzina commented Aug 23, 2024

Currently, the combined examples render the links to their embedded examples using <a> elements, which are inline. This causes the contents to be thrown from the baseline, meaning that individual examples are the only place where the baseline is adhered to.

We should wrap this in a paragraph to make sure the baseline is followed.

The change must be made here

Reported by @lyubomir-popov in SU last week

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-14463.

This message was autogenerated

@jmuzina jmuzina changed the title Update combined examples links to use block element rather than inline elements Update combined examples links to use correct baseline padding/margin Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant