Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve combined example baseline alignment #5327

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Aug 27, 2024

Done

Wraps the links/names for examples embedded in combined examples in a p rather than a div. This improves the baseline alignment of combined examples, as the links themselves should not throw the combined example off of the baseline.

Note that individual examples may still throw the combined example off of the baseline, if the component itself has margin/padding issues.

Fixes #5324, WD-14463

QA

  • Open any combined example. For example, typography combined.
  • Verify that the embedded example links are wrapped in a <p> and have correct paragraph padding & margin.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 27, 2024
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a huge issue (especially that the main purpose of those is Percy regression testing), but it's a simple improvement.

@jmuzina jmuzina merged commit 68ea703 into canonical:main Aug 30, 2024
12 checks passed
@jmuzina jmuzina deleted the combined-baseline-fix branch August 30, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update combined examples links to use correct baseline padding/margin
4 participants